Repository navigation
fix(build): propagate DUT worker failures - #198
Open
FU-max-boop wants to merge 1 commit into
Open
FU-max-boop wants to merge 1 commit into
FU-max-boop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiprocessing.AsyncResultand inspect it after all DUT workers finishUnsupportedDUTError, preserving wildcard and subtree buildsProblem
build_dut()submitted_build_dut()throughPool.apply_async()but discarded every returned result._build_dut()also only logged falsey returns and exceptions. A supported DUT build could therefore fail while the parent returned normally and the shell reported status 0.A process-level probe using a real Linux
multiprocessing.Pooland a synthetic supported builder returningFalsereproduced the behavior:Implementation
_build_dut()returnsTruefor success,Falsefor a falsey result or ordinary build exception, andNoneonly for an explicitUnsupportedDUTError.build_dut()records results under deterministically sorted DUT names, waits for all workers, then callsAsyncResult.get()for every submitted build.RuntimeError; exceptions fromAsyncResult.get()propagate.UnsupportedDUTError, so broad targets continue to skip them.Validation
e887def: 14 failed, 2 passed0 -> 1commre-export plus all six placeholder imports: passedgit diff --check: passedRelated work and merge ordering
#196 propagates pytest exit codes later in
run.py; this change covers the earlier DUT-build stage and does not overlap its files.A follow-up RAS contribution replaces
scripts/build_ut_frontend_bpu_ras.pywith a real builder. This PR should land first; the RAS branch will then retain its builder and drop that script from the unsupported set during rebase.Scope boundary