π‘οΈ Sentinel: [HIGH] Fix JPQL Injection in VocabularyController - #201
Conversation
π¨ Severity: HIGH π‘ Vulnerability: User input from autocomplete and search fields was directly concatenated into JPQL queries in `completeVocabulary` and `getSelectedItems`, allowing for JPQL injection. π― Impact: Attackers could manipulate the query to access unauthorized data or alter database logic. π§ Fix: Replaced string concatenation with parameterized queries using `java.util.Map` and explicitly used the `upper()` function on both sides of the `like` clause to maintain the intended case-insensitive search logic securely. β Verification: Ran `detect-maven.sh test` to ensure no regressions in existing tests. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel: [HIGH] Fix JPQL Injection in VocabularyController
π¨ Severity: HIGH
π‘ Vulnerability: User input from autocomplete and search fields was directly concatenated into JPQL queries in
completeVocabularyandgetSelectedItems, allowing for JPQL injection.π― Impact: Attackers could manipulate the query to access unauthorized data or alter database logic.
π§ Fix: Replaced string concatenation with parameterized queries using
java.util.Mapand explicitly used theupper()function on both sides of thelikeclause to maintain the intended case-insensitive search logic securely.β Verification: Ran
detect-maven.sh testto ensure no regressions in existing tests.PR created automatically by Jules for task 17633927196061055615 started by @manupawickramasinghe