π‘οΈ Sentinel: [HIGH] Fix JPQL injection in DoctorSpecialityController - #207
Conversation
Refactored `DoctorSpecialityController.completeSpeciality` to use a parameterized JPQL query instead of insecure string concatenation. Also replaced `qry.toUpperCase()` with JPQL's `upper()` for correct case-insensitive search logic. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: JPQL Injection vulnerability in
DoctorSpecialityController.completeSpeciality. Theqryparameter (from user input) was directly concatenated into the JPQL query string, allowing potential injection attacks.π― Impact: An attacker could craft a malicious payload in the autocomplete field to execute arbitrary JPQL queries, potentially leading to unauthorized data access or modification within the database scope.
π§ Fix:
:qry).HashMapto pass the sanitized input parameter.% + qry.toUpperCase() + %and using the JPQLupper(c.name)function (which fixes a subtle logical bug in the original code where the column itself wasn't uppercased).β Verification:
./detect-maven.sh test) and all 246 tests passed successfully.PR created automatically by Jules for task 11744389689903739417 started by @manupawickramasinghe