Repository navigation
Download only the MSIX artifact in the Windows signing job - #326
Open
JuergenFleiss wants to merge 2 commits into
Open
JuergenFleiss wants to merge 2 commits into
JuergenFleiss wants to merge 2 commits into
Conversation
The pattern aTrain-*-<version> also matches aTrain-macos-<version> and aTrain-macos-logs-<version>. When the macOS build finished first, its DMG went into the signed artifact and from there into the Windows Zenodo upload. Download the MSIX artifact by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows signing job downloaded
aTrain-*-<version>, which also matchesaTrain-macos-<version>andaTrain-macos-logs-<version>. When the macOS build finished first, its DMG went into the signed artifact and from there into the Windows Zenodo upload. Download the MSIX artifact by name instead.References
Split out of #323.
Screenshots / Examples
Verification Steps
build-windows-msix(aTrain-msix-<version><suffix>).artifacts/directly, somerge-multipleis no longer needed.