Repository navigation
Conversation
Merged
Parse and skip `extern crate self as name;` while continuing to reject other keywords in the crate name.
A negative marker applies to a trait impl. Trait aliases accept their bounds without the qualifiers used by trait declarations.
faysou
force-pushed
the
fix-extern-crate-self
branch
from
November 21, 2026 07:02
dceaced to
8368423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extern crate self as name;parses and formats with the same alias. Lookahead accepts the same crate names as parsing.Negative polarity is accepted for trait impls, while
impl !Type {}is rejected. Trait aliases rejectunsafeandautoqualifiers.The extern, impl, and trait test modules pass.
Related to #25.