Repository navigation
Conversation
With `default-features = false`, the dependency
`moxy = { features = ["ast", "quote"] }` failed to compile with
"unresolved import `moxy_token`": `quote` and `proc-macro2` enabled
`moxy-token` features only through a weak dependency
(`moxy-token?/quote`), which does not enable the optional `moxy-token`
dependency itself, while the root crate re-exports `moxy_token::quoted`.
Likewise `template` compiled alone, but the code `template!` generates
names `::moxy::token`, which then does not exist.
`ast`, `template`, `proc-macro2`, and `quote` now enable `token`, and
`fmt` enables `ast`, as the README's feature table already states. A CI
job checks `cargo check -p moxy --no-default-features --features <f>`
for each feature alone, since the test job builds with all features.
faysou
force-pushed
the
fix-isolated-features
branch
from
November 21, 2026 07:02
df41cec to
3701c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the dependencies that
ast,fmt,template,proc-macro2, andquoteneed when enabled without default features. Add a CI job that checks each public feature on its own.All twelve individual feature checks pass locally.
Related to #25.