Repository navigation
Allow crate/super/self in use paths - #40
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 62.30% 62.21% -0.10%
==========================================
Files 272 273 +1
Lines 18161 18226 +65
==========================================
+ Hits 11315 11339 +24
- Misses 6846 6887 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
thanks for the contribution @antonWetzel, please add fixture coverage to the grammar matrix https://github.com/aacebo/moxy/tree/master/fixtures/grammar/paths which should increase test coverage to the acceptable amount. |
Contributor
Author
|
I added a test to the fixtures. I updated the test matrix json by hand, no clue if this is correct. The |
aacebo
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of using
Identin paths, use newUseSegment, which also allowssuper,selfandcrate.Reference:
Notes:
visiblity/macros/attributes$cratesegment is not includedMotivation
Generated code with
use super::*lost it during parse asFileand format round trip.Validation
Compatibility
identtosegmentIdenttoUseSegmentChecklist