Skip to content

mergequeue: Await preparation results - #1488

Merged
abhinav merged 1 commit into
merge-execution-refactorfrom
merge-scheduler-prepare-fix
Oct 26, 2026
Merged

abhinav merged 1 commit into
merge-execution-refactorfrom
merge-scheduler-prepare-fix

Conversation

@abhinav

@abhinav abhinav commented Oct 25, 2026

Copy link
Copy Markdown
Owner

A prepared item and its dependents can disappear from the queue without
a completion, failure, or skip outcome.
The single prepare worker can accept another item as soon as it buffers
a result, before the scheduler consumes that result.
Consuming the older result then clears the preparing flag for the newer
call, allowing the scheduler to return while preparation is still running.

Keep preparation admission closed until its result has been consumed.
Serializing worker calls alone does not preserve that accounting;
the scheduler must acknowledge each call before dispatching the next.

@abhinav

abhinav commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

A prepared item and its dependents can disappear from the queue without
a completion, failure, or skip outcome.
The single prepare worker can accept another item as soon as it buffers
a result, before the scheduler consumes that result.
Consuming the older result then clears the preparing flag for the newer
call, allowing the scheduler to return while preparation is still running.

Keep preparation admission closed until its result has been consumed.
Serializing worker calls alone does not preserve that accounting;
the scheduler must acknowledge each call before dispatching the next.
@abhinav
abhinav force-pushed the merge-scheduler-prepare-fix branch from caf96a8 to 8debf53 Compare October 25, 2026 23:56
@abhinav
abhinav added this pull request to stack #1491 October 25, 2026 23:56
@abhinav
abhinav merged commit c0dc6fd into main Oct 26, 2026
22 checks passed
@abhinav
abhinav deleted the merge-scheduler-prepare-fix branch October 26, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant