Repository navigation
mergequeue: Await preparation results - #1488
Merged
Merged
Conversation
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Oct 25, 2026
A prepared item and its dependents can disappear from the queue without a completion, failure, or skip outcome. The single prepare worker can accept another item as soon as it buffers a result, before the scheduler consumes that result. Consuming the older result then clears the preparing flag for the newer call, allowing the scheduler to return while preparation is still running. Keep preparation admission closed until its result has been consumed. Serializing worker calls alone does not preserve that accounting; the scheduler must acknowledge each call before dispatching the next.
abhinav
force-pushed
the
merge-scheduler-prepare-fix
branch
from
October 25, 2026 23:56
caf96a8 to
8debf53
Compare
This was referenced Oct 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prepared item and its dependents can disappear from the queue without
a completion, failure, or skip outcome.
The single prepare worker can accept another item as soon as it buffers
a result, before the scheduler consumes that result.
Consuming the older result then clears the preparing flag for the newer
call, allowing the scheduler to return while preparation is still running.
Keep preparation admission closed until its result has been consumed.
Serializing worker calls alone does not preserve that accounting;
the scheduler must acknowledge each call before dispatching the next.