Repository navigation
github: Fix native stacks on GHE.com - #1499
Merged
Merged
Conversation
Native stack updates and atomic merges are skipped when `spice.forge.github.apiUrl` points to `https://api.<tenant>.ghe.com`. The gateway appends `/v3` to REST requests for every host except `api.github.com`, but GHE.com serves REST at the API host root. The stack probe interprets the resulting 404 as an unsupported feature, so callers silently fall back to ordinary PR operations. GraphQL requests already use the correct `/graphql` endpoint. Recognize GHE.com API hosts alongside `api.github.com` when selecting the REST base, preserving `/api/v3` for Enterprise Server. Centralize web URL defaults and API endpoint derivation in `Deployment`: github.Deployment{URL: o.URL, APIURL: o.APIURL} The forge forwards its raw URL settings, and the gateway resolves the protocol endpoints, so deployment URL rules have one owner. Keep web URL selection independent of API parsing, which still occurs when opening a repository. Fixes #1498
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native stack updates and atomic merges are skipped when
spice.forge.github.apiUrlpoints tohttps://api.<tenant>.ghe.com.The gateway appends
/v3to REST requests for every host exceptapi.github.com, but GHE.com serves REST at the API host root.The stack probe interprets the resulting 404 as an unsupported feature,
so callers silently fall back to ordinary PR operations.
GraphQL requests already use the correct
/graphqlendpoint.Recognize GHE.com API hosts alongside
api.github.comwhen selectingthe REST base, preserving
/api/v3for Enterprise Server.Centralize web URL defaults and API endpoint derivation in
Deployment:The forge forwards its raw URL settings, and the gateway resolves the
protocol endpoints, so deployment URL rules have one owner.
Keep web URL selection independent of API parsing,
which still occurs when opening a repository.
Fixes #1498