Skip to content

AMPERE downloads - #164

Merged
aburrell merged 16 commits into
developfrom
ampere_downloads
Sep 21, 2026
Merged

aburrell merged 16 commits into
developfrom
ampere_downloads

Conversation

@aburrell

@aburrell aburrell commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Description

Fixes #156 by removing the AMPERE boundary files and adding download/formatting functions. This is also preferable, because Steve can keep updating the files without having to tell me about it and ocbpy won't be out-of-date.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unit tests

Test Configuration

  • Operating system: OS X Tahoe
  • Version number: Python 3.10
  • Any details about your local setup that are relevant: rc branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My commits are formatted appropriately (following the SciPy/NumPy style)
  • My code follows the style guidelines of this project
  • I assert that I have not used AI in the development of this pull request
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

Because it is getting too large to provide data as a part of the package, I have added routines to download and format the AMPERE data files.  This allows updates to the data files to not require a package update, as well, unless the format changes.
Added optional dependencies for AMPERE downloads, and also added some combination options for installation.
Updated the AMPERE boundary description to link to the general version of the data and point to the download and formatting routines.
Updated the AMPERE dataset citation to point to the general dataset instead of a specific version.
Added a summary of changes to the changelog.
Remove the old AMPERE boundary files.
Sort the downloaded AMPERE files so that the boundary files are sorted by time when created.
Fixed a typo in the docstrings.
Added AMPERE test boundary files so that unit tests not related to downloads do not need to download data.
Updated the files tests for the absence of AMPERE data in the boundaries directory by default.
Added southern AMPERE data to test directory for testing without downloads.
Sort the AMPERE files by hemisphere, to avoid writing files with data that isn't present.
Removed extra whitespace.
Removed an error catch that couldn't be reached directly, and would be caught sensibly by the next routine.
Added tests for the AMPERE downloads and file formatting.
Updated the CI to test the DMSP SSJ and AMPERE downloads in a single run.
@aburrell aburrell added this to the v1.0.0 milestone Sep 18, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 99.481%. first build — ampere_downloads into develop

@aburrell
aburrell merged commit 2757b67 into develop Sep 21, 2026
100 checks passed
@aburrell
aburrell deleted the ampere_downloads branch September 21, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants