Troyer model - #165
Merged
Merged
Troyer model#165
Conversation
Add the AMPERE Milan and formatted ocbpy files to the .gitignore.
Added the new optional dependency to the README.
Added documentation for the Troyer model.
Added the Troyer model for the EAB.
Updated the model description to speak to the probabilistic option that is not implemented here.
Added unit tests for the Troyer model.
Added a note about the percentile to the Troyer docstring.
Added the Troyer model update to the changelog.
2 tasks done
aburrell
commented
Sep 21, 2026
aburrell
commented
Sep 21, 2026
Fixed typos in the references and removed extra whitespace. Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Owner
Author
|
@rileytroyer let me know what you think! |
Ensure that a float input into the Gussenhoven model leads to a float output.
Added a test for the float input/output for the Gussenhoven model.
rileytroyer
reviewed
Sep 23, 2026
rileytroyer
reviewed
Sep 23, 2026
| return rad | ||
|
|
||
|
|
||
| def troyer_equatorward_auroral_boundary(mlt, hp=0): |
There was a problem hiding this comment.
For future builds, assuming availability, would you envision including a argument to specify the specific percentile, or would you have that as a separate function?
Owner
Author
There was a problem hiding this comment.
I think I'd add a kwarg that defaults to 50 or .5 (depending on how we formulate it) for the fully probabilistic code. Maybe even allow array-like input/output for less computations and an ensemble output? I look forward to upgrading it in the future!
Fixed the casting of float output for the Gussenhoven model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #153 by adding the Troyer model. Also adds AMERE files to the .gitignore.
Type of change
How Has This Been Tested?
Added unit tests.
Test Configuration
Checklist:
develop(notmain) branchChangelog.rst, summarising the changesAUTHORS.rstand.zenodo.json