Repository navigation
Conversation
slydiman
force-pushed
the
swift/cas-diag-stats
branch
2 times, most recently
from
October 8, 2026 19:11
ea855a8 to
6483165
Compare
slydiman
force-pushed
the
swift/cas-diag-stats
branch
from
October 9, 2026 08:32
6483165 to
3379b4a
Compare
tagolog
reviewed
Oct 9, 2026
|
|
||
| //SmallString<100> MsgBuf; | ||
| //Info.FormatDiagnostic(MsgBuf); | ||
| // std::string Message(MsgBuf); |
There was a problem hiding this comment.
Is this commented-out code still needed, or can we safely remove it?
Contributor
Author
There was a problem hiding this comment.
Sure, we can remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the CAS statistics stored in the binary
statsfile in CAS directory.llvm-cas --show-stats -cas <CASPath>shows something likellvm-cas --zero-stats -cas <CASPath>resets the statistics.Note the compiler should use
-Xclang -Rcompile-job-cache-timing -Xclang -Rcompile-job-cacheto get it working.We can disable CacheStatsDiagnosticConsumer if
compile-job-cacheremarks are disabled.We can create custom remarks enabled by default and add extra Diag.Report() wherever
compile-job-cache-*are reported.Note
TextDiagnosticPrinterwill printcompile-job-cacheor any custom remarks anyway to stdout.