Repository navigation
Conversation
|
Hello @tagolog 👋 Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.
Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description. Frequently asked questionsHow do I add reviewers? This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically. You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using What if there are no comments? If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers. Are any special GitHub settings required to contribute to LLVM? We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details. If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse. Thank you, |
tagolog
changed the title
In daemon mode the -cc1depscan client opened the CAS a second time, after the daemon had already done the scan, only to run parseID() on the root ID string the daemon sent back. The resulting CASID was used for nothing but -dump-depscan-tree, which prints it as a string again. Opening the on-disk CAS is expensive on Windows - about 1.3 ms per compile, 2.6 ms per cache hit with eight parallel clients. Keep the root ID as a std::string in the client, so it no longer opens the CAS in daemon mode at all. The compile parses the same ID from -fcas-include-tree.
ff26d4a to
face485
Compare
|
PR was migrated to github.com / swiftlang / llvm-project / pull / 14708 |
In daemon mode the -cc1depscan client opened the CAS a second time, after the daemon had already done the scan, only to run parseID() on the root ID string the daemon sent back. The resulting CASID was used for nothing but -dump-depscan-tree, which prints it as a string again. Opening the on-disk CAS is expensive on Windows - about 1.3 ms per compile, 2.6 ms per cache hit with eight parallel clients.
Keep the root ID as a std::string in the client, so it no longer opens the CAS in daemon mode at all.
The compile parses the same ID from -fcas-include-tree.