Skip to content

[Support] Check whether a file is local by its handle on Windows - #225

Draft
tagolog wants to merge 1 commit into
swift/stable/23.xfrom
tagolog/check-is-file-local-by-its-handle-on-windows
Draft

tagolog wants to merge 1 commit into
swift/stable/23.xfrom
tagolog/check-is-file-local-by-its-handle-on-windows

Conversation

@tagolog

@tagolog tagolog commented Oct 17, 2026 •

Copy link
Copy Markdown

To tell whether an open file is on a local disk, is_local resolved
its handle to a path with GetFinalPathNameByHandleW, found the volume
with GetVolumePathNameW and classified it with GetDriveTypeW.
This chain is pretty expensive. GetVolumePathNameW alone
takes 0.2-0.4 ms. mapped_file_region does this check on every unmap,
slowing down the on-disk CAS.

Ask the volume through the handle first. NtQueryVolumeInformationFile
returns the device type in one call. DRIVE_FIXED means the drive is
a fixed local disk. Any other answer, or a failed query, falls back to
the path-based check as before.

A cache hit of a single-file compile is 2.1% faster through the
dependency scanning daemon and 1.4% faster in-process. Measured with
clang compile caching on the on-disk CAS in the swiftlang/llvm-project
fork.

@github-actions

Copy link
Copy Markdown

Hello @tagolog 👋

Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.

  • All contributions to LLVM must follow our LLVM AI Tool Use Policy. In particular, if you used AI while working on this PR, remember to add a note to the PR description.
  • The LLVM Code-Review Policy and Practices document contains practical information about the PR process, including how patches are reviewed and accepted, and who can review a PR.
  • Our LLVM Developer Policy describes our expectations for code quality, commit summaries and contains notes on our CI system.

Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description.


Frequently asked questions

How do I add reviewers?

This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically.

You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using @ followed by their GitHub username.

What if there are no comments?

If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers.

Are any special GitHub settings required to contribute to LLVM?

We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details.


If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse.

Thank you,
The LLVM Community

@tagolog
tagolog requested review from andreil99, asl and slydiman October 17, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant