Repository navigation
fix: resolve pre-release timeline and form display defects - #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A successfully committed background extraction appeared as an interrupted foreground turn after recovery. Each turn added another false failure below the story. Join worker reasoning to its durable source task using
backgroundTurnId, preserving the job's outcome and deduplicating reasoning regardless of hydration order.The second fix addresses repeated full stops in the model-generated opening form found during the same packaged playthrough.
Type of change
Evidence
expected 1 row, received 2); the macOS app accumulated three false failed turns after opening and two player turns, while all three background receipts weresuccess / committed.After: both hydration orders and repeated recovery produce one source-task row. The reinstalled DMG restored the same profile without the false failures; a third player turn and fourth extraction completed and remained correct after refresh.
After: all 42 submit-form cases pass, including preservation of stored defaults and ellipses. Replaying the exact form recorded by the native app produces no repeated full stops.
Verification
All local commands used the mise toolchain.
pnpm checkpnpm test— 43 successful tasks on the final codepnpm test:pgpnpm e2e— complete production-build browser suitepnpm release:preflightNot verified: interactive Windows GUI playthrough; real image/audio generation. The live-model flow used the configured
magpie / codex/gpt-6-lunaroute and an isolated home/profile. No production user data was modified.Breaking changes
None. No storage schema, provider routing or plugin contract changes; no development data must be recreated.
Related context
Found during pre-release packaging and native acceptance testing after #173. The user observed false
extractfailures accumulating at the bottom of the UI.Docs sync
docs/reference/protocol.mddescribes worker/source correlation and durable status ownership.docs/reference/tools.mddocuments interpolation-boundary punctuation.docs/CHANGELOG.mdrecords both user-visible fixes under Unreleased.Merge Danger
Door: Two-way
Both changes can be reverted without changing stored input or committed game state.
Blast Radius: Presentation
Timeline recovery and filled interaction narrative text. Actual job failures retain their authoritative errors; punctuation is removed only when a template full stop immediately duplicates the filled value's final character.