Repository navigation
fix(desktop): readable startup error text in light mode - #243
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiABm7VuSQwevB8WsHx6EL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by yy · project thread
Summary / 摘要
The desktop startup screen follows the system colour scheme, but its light-mode rules skipped the error block. When startup failed with the system in light mode, the error message (
#a1a1aa) and hint (#d4d4d8) were drawn in near-white text on the#fafafabackground, and the red error title and the spinner's centre dot were faint. The light-mode block now gives them dark colours (#52525b,#3f3f46,#dc2626,#71717a). Like the other rules in that block they carry!important, because the block comes before the base rules in the stylesheet.Found while reviewing the v0.0.50 Windows splash change from #163. It applies on every platform.
Type of change / 变更类型
Verification / 验证方式
pnpm check: could not run in this environment. Turbo fails to spawn child processes (Exec format error), and the container has Node 22, not Node 26.pnpm --filter-equivalentpnpm testinapps/desktoppasses.node scripts/changelog.mjs check: 1 valid fragment.Not verified / 未验证: Nobody looked at the screen. The change is four CSS rules inside the existing
prefers-color-scheme: lightblock.Related issue / context / 关联
#163
Docs sync / 文档同步
docs/changelog.d/splash-light-error-text.mdAGENTS.md🤖 Generated with Claude Code
https://claude.ai/code/session_01HiABm7VuSQwevB8WsHx6EL
Generated by Claude Code