Repository navigation
fix(site): ship the icon the page links to - #249
Merged
Merged
Conversation
The header, footer and favicon referenced icon.png, which apps/site/public never had, so the published site showed broken images. Copy the app icon. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WsmAtQVpExwtdV7icT6Vii
The root .gitignore ignores *.png with per-file exceptions, so the icon was never committed. Add apps/site/public/icon.png to the exceptions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WsmAtQVpExwtdV7icT6Vii
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by yy · project thread
Summary / 摘要
Before: the published showcase site (https://heywe.cn/covel/) showed a broken icon in the header and footer and had no favicon, because
icon.pngreturned 404. The root.gitignoreignores*.pngwith per-file exceptions, andapps/site/public/icon.pngwas not one of them, so the file was never committed when the site was split from the web app.After:
apps/site/public/icon.png(a copy ofapps/web/public/icon.png) is tracked through a new.gitignoreexception, so all three places show the Covel icon.Type of change / 变更类型
Verification / 验证方式
pnpm check:changelog,pnpm --filter @covel/site test(12 passed)https://heywe.cn/covel/icon.pngis 404 after ci(site): deploy the showcase site to GitHub Pages #248 deployed whilescreens/*.webpload.Not verified / 未验证: the redeploy; it runs after merge.
Related issue / context / 关联
Follow-up to #248.
Docs sync / 文档同步
docs/changelog.d/site-icon.md🤖 Generated with Claude Code
https://claude.ai/code/session_01WsmAtQVpExwtdV7icT6Vii