Repository navigation
fix: migrate documentation generation to DuckDB 2.0 - #328
Merged
Mandukhai-Alimaa merged 1 commit intoOct 29, 2026
Merged
Mandukhai-Alimaa merged 1 commit into
Mandukhai-Alimaa merged 1 commit into
Conversation
Mandukhai-Alimaa
force-pushed
the
fix/duckdb-2-migration
branch
from
October 29, 2026 22:04
71878c4 to
9247e90
Compare
lidavidm
reviewed
Oct 30, 2026
|
|
||
| def _query(query: str) -> duckdb.DuckDBPyRelation: | ||
| result = duckdb.sql(query) | ||
| assert result is not None |
Contributor
There was a problem hiding this comment.
Huh, why is this necessary?
Contributor
Author
There was a problem hiding this comment.
DuckDB 2.0 types sql() as DuckDBPyRelation | None, causing CI type-check failures. The assertion narrows the type for ty, since these queries always return a relation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #326. Update documentation generation to handle optional query results and use DuckDB 2.0's statement execution and Arrow conversion APIs.