Repository navigation
docs: the queue classifier has ten causes, three of which add a runner - #120
Conversation
The README said eight causes and that exactly one offers to add a runner. lib/queue-cause.js defines ten (CAUSES), and three return actionEligible = true: unserved, role-unserved and repo-capacity. That matches docs/concepts.md and the queue-causes figure, which already say ten and three. Two comments in queue-cause.js carried older counts too: "two of seven causes" and "the six causes marked false" (seven are marked false), and the unserved branch called itself the only action-eligible non-capacity cause, which role-unserved no longer leaves true. Comments only; no behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019W86FcknjPBqAPtVcnH8Ja
|
Shell tests failed on
Everything else passed (148 of 150 in that file), and so did the other eight jobs. This PR changes only a README paragraph and three comments in There's no fix for these two yet. #76 makes a similar change for two other timing checks but doesn't touch the lanes-observe ones. A patch in that spirit would be to allow a one-second tolerance, e.g. I'm rerunning the failed job once. Generated by Claude Code |
|
The Generated by Claude Code |
Summary
The README says the queue classifier has eight causes and that exactly one offers to add a runner. Neither matches the code:
dashboard/lib/queue-cause.jsdefines ten entries inCAUSES.actionEligible = true:unserved,role-unservedandrepo-capacity.docs/concepts.md(the README's own link target) anddocs/figures/queue-causes.htmlalready say ten and three. Only the README was behind. tayloraddison.dev's case study on this project cites ten, which is how the mismatch came up.Two comments in
queue-cause.jscarried older counts too, so I fixed them in the same change:unservedbranch called itself action-eligible "unlike every other non-capacity cause"role-unservedexists; now names bothComments and README only, no behaviour change.
Platform tested on
node -v→ v22.22.0Checklist
cd dashboard && npm test(1112 tests: 1111 pass, 0 fail locally; green in CI)scripts/release-check.sh --offline. It couldn't run locally (no authenticatedgh), but CI's "Release check (offline)" passed ona43fa05.docs/concepts.md)Also run:
node --checkon every tracked.jsfile,make-skill.mjs --check("skill is up to date"),make-glance-fixtures.mjs --check(exit 0) andscripts/check-docs.sh(done, all ok).CI note: "Shell tests" failed once on two
lane_wait_s == 0timing assertions in the admission-hook tests, which this PR doesn't touch (details in the comment below). It passed on one rerun.🤖 Generated with Claude Code
https://claude.ai/code/session_019W86FcknjPBqAPtVcnH8Ja