Repository navigation
ci: ci-ok runs unless the run was cancelled - #111
Merged
Merged
Conversation
always() also ran it on a run that concurrency cancel-in-progress had cancelled, and it failed on the cancelled jobs: a red check for a commit nobody was judging any more (taylab-launch-kit v1.40.4). It still runs when a job fails or times out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 5 tasks
addisdev
added a commit
that referenced
this pull request
Oct 25, 2026
always() also ran ci-ok on a run that concurrency cancel-in-progress had cancelled, and it failed on the cancelled jobs: 18 of the 25 ci-ok failures 10-11..10-21 were that. Cherry-pick of 56cb295 (#111) from develop. A cancelled run's ci-ok now concludes cancelled (checked on this PR), which still does not satisfy the required check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jHjgRysB6GajV3oDppruf
addisdev
pushed a commit
that referenced
this pull request
Oct 26, 2026
Brings back what landed on main without going through develop: #112 (Node.js 24 action majors), #114 (already here as #111; identical), #110 vite 7.3.7, #109 fastify 5.12.6, #113 fast-uri, and #116 (gradlew.bat and OFL-IBMPlex.txt stored with LF). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jHjgRysB6GajV3oDppruf
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line: the
ci-okjob'sif: always()becomesif: ${{ !cancelled() }}.Why: with
concurrency: cancel-in-progress, a newer push cancels the running run, andalways()still ranci-ok, which then failed on the cancelled jobs. In Jerv that was about 7 of 16 red gates 10-20..10-23 (runs 39962971234, 39866680011, 39863023360, 39861510190, 39852318773, 39834644844; each runcancelled,gate / gatefailure), and DiscoBeat 4 of 20. A cancelled run'sci-okis now skipped; its cancelled jobs still showcancelled(read as red by Upkeep and pr-autoreview), and the newer run'sci-okis the verdict.ci-okstill runs, and still fails, when a job fails or times out.Same change as the kit's own templates and web-e2e gate: addisdev/taylab-launch-kit#267 (v1.40.4). This PR does not depend on it.
🤖 Generated with Claude Code