Skip to content

Store gradlew.bat and the IBM Plex licence with LF, as .gitattributes says - #116

Merged
addisdev merged 2 commits into
mainfrom
claude/determined-bohr-32nsy5
Oct 26, 2026
Merged

addisdev merged 2 commits into
mainfrom
claude/determined-bohr-32nsy5

Conversation

@addisdev

@addisdev addisdev commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

What and why

Two files were committed with CRLF inside the repository, against .gitattributes. A repo-wide git add --renormalize . finds only these two; after this PR it finds none.

  • runner-android/gradlew.bat: *.bat is text eol=crlf, meaning LF in the repository and CRLF on checkout. Because the repository copy was CRLF, git status showed the file as modified on every fresh clone and worktree although nobody had touched it (it came up while working on ci: ci-ok runs unless the run was cancelled (port #111 to main) #114). A checkout still writes CRLF, which is what cmd.exe needs.
  • docs/figures/fonts/OFL-IBMPlex.txt: * text=auto eol=lf wants LF everywhere. It was the only CRLF text file in that folder; OFL-Bricolage.txt is already LF. Nothing reads it byte for byte; NOTICE.md only links to it.

Both were renormalized with git add --renormalize, one commit each. Only line endings change.

Verified

  • git diff --ignore-cr-at-eol on each commit is empty: no content change.
  • Neither file has a CR left in the repository copy. A fresh worktree of the head has a clean git status. gradlew.bat reads i/lf w/crlf with all 82 lines CRLF on disk; OFL-IBMPlex.txt reads i/lf w/lf.
  • mkdocs build --strict with the pinned requirements-docs.txt passes locally.
  • CHANGELOG.md: not user-visible.

What is still not true

  • Not run: gradlew.bat itself. No CI job runs the wrapper on Windows; the runner-android job uses ./gradlew on Linux.
  • develop holds the same two blobs and keeps them until the next release brings these commits across.

🤖 Generated with Claude Code

https://claude.ai/code/session_019jHjgRysB6GajV3oDppruf

.gitattributes marks *.bat as `text eol=crlf`: LF in the repository, CRLF
in the working tree. gradlew.bat was committed with CRLF inside the
repository, so git reported it as modified on every fresh checkout, with
nobody having touched it. Renormalized with `git add --renormalize`. The
content is unchanged apart from line endings, and a checkout still writes
CRLF, which is what cmd.exe needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019jHjgRysB6GajV3oDppruf
`* text=auto eol=lf` wants LF both in the repository and on checkout.
OFL-IBMPlex.txt was committed with CRLF, the one text file under
docs/figures/fonts/ that was (OFL-Bricolage.txt is LF). Renormalized
with `git add --renormalize`; the licence text is unchanged apart from
line endings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019jHjgRysB6GajV3oDppruf
@addisdev addisdev changed the title runner-android: store gradlew.bat with LF, as .gitattributes says Store gradlew.bat and the IBM Plex licence with LF, as .gitattributes says Oct 26, 2026
@addisdev
addisdev merged commit bfbd0da into main Oct 26, 2026
14 checks passed
addisdev pushed a commit that referenced this pull request Oct 26, 2026
Brings back what landed on main without going through develop:
#112 (Node.js 24 action majors), #114 (already here as #111; identical),
#110 vite 7.3.7, #109 fastify 5.12.6, #113 fast-uri, and #116 (gradlew.bat
and OFL-IBMPlex.txt stored with LF).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019jHjgRysB6GajV3oDppruf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants