Repository navigation
EXP interface enhancements #423
Description
Once #413 is in, and EXP-code/EXP#136 is addressed, we should:
- Use getAccel() to compute the acceleration instead of getFields (to save on computation)
- Improve C++ exception handling (e.g., evaluating interpolator at a time outside of range)
- Improve speed and benchmark against pyEXP orbit integration
- Hessian
- Pickling, saving, and loading an
EXPPotentialinstance
cc @lgarrison
Activity
lgarrison commentedon Oct 15, 2025
As discussed today, we'll try to rebuild the EXP interface to use PyEXP objects. We will probably extract the EXP objects/pointers at the Python level and pass those to the Gala-EXP extension. The extension will thus depend on EXP but not PyEXP, although PyEXP will be a Python dependency.
For the existing API of passing filename strings, we can make PyEXP objects under the hood and use those.
adrn commentedon Oct 20, 2025
From @The9Cat:
The9Cat commentedon Oct 20, 2025
I've overloaded
getAccel()in the C++ inteface in EXP-code/EXP#170 so that both versions should bind and changed the pyEXP interface accordingly. This is probably the better choice? Not sure. Good for me either way.