Repository navigation
Conversation
TimeInterpolatedWrapper stored 0.0 as G in _params, and __reduce__ passes _params[0] back as G, so the unpickled wrapper interpolated with G = 0. Pass the real G to init(). Fixes adrn#542
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pickling or deep-copying a
TimeInterpolatedPotentialgave back a potential whose energy, gradient and density were all zero.TimeInterpolatedWrappercalledself.init([0.0], ...), and__reduce__passesself._params[0]back asG. So the rebuilt wrapper set up its interpolation state withG = 0. This change passes the realGtoinit(). Thetime_interp_*C functions never readpars, so nothing changes for a potential that was not pickled.Tested:
test_potential_timeinterpolated_539.pynow compares energy, gradient and density before and after unpickling. Onmainit fails (0.vs-0.0189); with this change it passes.deepcopyby hand for Kepler (interpolatedm), Hernquist (m,c, moving origin), SCF, and insideCompositePotential/CCompositePotential.tests/suite (benchmarks excluded) passes locally with GSL 2.8.Fixes #542