[CLIENT-3879] feat!: have client.remove_bin() raise ParamError instead of ClientError for invalid policy keys - #1230
Merged
juliannguyen4 merged 8 commits intoSep 14, 2026
Conversation
…eation methods that already take in a ctx parameter
…ite in case it fails instead of overriding with a generic ClientError
juliannguyen4
changed the base branch from
v20
to
CLIENT-2468-rm-deprecated-index-creation-apis
September 10, 2026 17:22
juliannguyen4
changed the title
Base automatically changed from
CLIENT-2468-rm-deprecated-index-creation-apis
to
v20
September 11, 2026 16:10
…-raise-ParamError-instead-of-ClientError-for-invalid-policy-keys
…Error and remove_bin() no longer overrides it with ClientError, causing unintended breaking changes to users who may pass in an invalid policy rejected by pyobject_to_policy_write
…-raise-ParamError-instead-of-ClientError-for-invalid-policy-keys
… overwrote the last error message.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v20 #1230 +/- ##
==========================================
- Coverage 85.77% 85.76% -0.01%
==========================================
Files 102 102
Lines 14948 14945 -3
==========================================
- Hits 12821 12817 -4
- Misses 2127 2128 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…-raise-ParamError-instead-of-ClientError-for-invalid-policy-keys
juliannguyen4
marked this pull request as ready for review
September 14, 2026 15:33
juliannguyen4
deleted the
CLIENT-3879-remove_bin-raise-ParamError-instead-of-ClientError-for-invalid-policy-keys
branch
September 14, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.