Repository navigation
feat(domains): show how each server renews certificates on the Domains page - #72
Merged
Merged
Conversation
…s page Certificates are renewed only through port 443 (tlsChallenge), but the panel never showed it. An old server could still have httpChallenge in traefik.yml or publish port 80, and nothing pointed that out until a renewal failed. The Domains page now opens with a "Certificate renewal" table with one row for the panel and one for each server: - Method: the ACME challenge in traefik.yml (tlsChallenge on 443, httpChallenge that needs port 80, dnsChallenge, or none). - Published ports: the host ports of the dokploy-traefik container or swarm service, and whether port 80 is open. The configured bindings are read, so a stopped container still shows them. - What to do: httpChallenge, an open port 80 or a missing 443/tcp are listed with the fix (save the Traefik port mappings once, which converts the config and recreates Traefik). There is no switch: the only other method needs port 80, which stays closed. The check runs as one more stage of the existing per-server read and does not affect whether unused certificates are listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Certificates are renewed only through port 443 (
tlsChallenge), but the panel never showed it. An old server could still havehttpChallengeintraefik.ymlor publish port 80, and nothing pointed that out until a renewal failed.What
The Domains page now opens with a Certificate renewal table. It has one row for the panel and one for each server:
traefik.yml: TLS-ALPN-01 on 443, HTTP-01 (needs port 80), DNS-01, or nonedokploy-traefikcontainer or swarm service, and whether port 80 is open. Configured bindings are read, so a stopped container still shows themhttpChallenge, an open port 80 or a missing 443/tcp: the fix (save the Traefik port mappings once; that converts the config and recreates Traefik)There is no switch, because the only other method needs port 80, which stays closed.
The check is one more stage of the existing per-server read (
readServer). It does not affectusageVerified, so it never hides the unused-certificate list.docs/certificates-and-ports.mddescribes the table.Independent of #71.
Tests
certificate-renewal.test.tsruns the real shell command with a fakedockerand a temporarytraefik.yml. Cases:httpChallengetogether with port 80;httpChallenge;certificateRenewalreaches the page data.apps/dokploytypecheck passes.🤖 Generated with Claude Code