Conversation
artberger
commented
Aug 12, 2026
Collaborator
- source token in xaa
- jwtSign
- token types
- tool calls
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Deploying agentproxy with
|
| Latest commit: |
7e56048
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e6558c5.agentproxy.pages.dev |
| Branch Preview URL: | https://adb-fixes.agentproxy.pages.dev |
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
|
|
||
| The gateway extracts tool calls from every response format that it supports, including streaming responses. For a streaming response, the gateway assembles the argument fragments from the individual chunks into one value when the stream ends, so a set of arguments that the provider splits across several chunks still arrives as one object. | ||
|
|
||
| When a response carries no tool calls, the gateway omits the attribute from the log line completely, rather than recording an empty array. Filter for the attribute name to find the requests that used tools. |
Collaborator
There was a problem hiding this comment.
assuming this is true for traces also, but might be worth adding
Nadine2016
reviewed
Aug 12, 2026
| When a response carries no tool calls, the gateway omits the attribute from the log line completely, rather than recording an empty array. Filter for the attribute name to find the requests that used tools. | ||
|
|
||
| > [!NOTE] | ||
| > Reading `llm.toolCalls` has a performance cost for large responses, because the gateway inspects the response body. Add the attribute where the tool calls matter, rather than to every route. |
Collaborator
There was a problem hiding this comment.
I can't understand the second sentence
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
| expression: jwt.id_token | ||
| ``` | ||
|
|
||
| The `jwt` variable holds the claims of the token that the JWT authentication policy validated, so an expression can read only a claim that arrived signed. The exchange runs on the extracted ID token, and the outer access token is never sent to either token endpoint. |
Collaborator
There was a problem hiding this comment.
not sure I understand what it means with outer access token
Nadine2016
reviewed
Aug 12, 2026
|
|
||
| ### When the source yields no credential {#subject-token-empty} | ||
|
|
||
| The gateway does not fall back to another location. If the configured source yields nothing, the request fails with a `400` and the message `invalid request`, and the gateway does not call the identity provider. The following cases all fail this way: |
Collaborator
There was a problem hiding this comment.
I feel like this could be summarized to 1 or 2 sentences and added further up where you explain how to set the source
Nadine2016
reviewed
Aug 12, 2026
| | `audiences`, `scopes`, `resources` | The `audience`, `scope`, and `resource` parameters sent to the token endpoint. `resources` are [RFC 8707](https://datatracker.ietf.org/doc/html/rfc8707) resource indicators. | | ||
| | `subjectToken` | Where to read the incoming credential and its `tokenType` (`AccessToken`, `Jwt`, and so on). Defaults to the `Authorization: Bearer` header. | | ||
| | `actorToken` | Optional RFC 8693 delegation actor token (`TokenExchange` grant only). | | ||
| | `subjectToken` | Where to read the incoming credential and its `tokenType`, which is either a built-in name such as `AccessToken`, `Jwt`, or `IdToken`, or a custom absolute URI, as described in [Token types](#token-types). Defaults to the `Authorization: Bearer` header, with the type `AccessToken`. | |
Collaborator
There was a problem hiding this comment.
is accesstoken, jwt, etc the type of token and the authorization header is the source? if so maybe update that sentence.
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
Nadine2016
reviewed
Aug 12, 2026
| | `ttl` | Optional token lifetime that the gateway uses for `exp`. Defaults to `300s`. | | ||
| | `location` | Optional location that the gateway writes the signed token to. Defaults to the `Authorization` header with a `Bearer` prefix. Set exactly one of `header`, `queryParameter`, or `cookie` to change it. At a custom location, the gateway writes the bare token with no `Bearer` prefix. | | ||
|
|
||
| 2. Only `signingKeyRef` is required. A policy that sets nothing else signs with `RS256` and a 300-second lifetime, and writes the token to the `Authorization` header. |
Collaborator
There was a problem hiding this comment.
not sure why this is a step
Signed-off-by: Art Berger <art.berger@solo.io>
Signed-off-by: Art Berger <art.berger@solo.io>
Co-authored-by: Nadine Spies <nadinekipsch@onlinehome.de> Signed-off-by: Art <artberger@users.noreply.github.com>
Nadine2016
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.