Repository navigation
governance: hand maintainer coverage to community maintainers - #318
Conversation
Refs agentrust-io/.github#60 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
carloshvp
left a comment
There was a problem hiding this comment.
Reviewed exact head f850e96a4ee5cbff3dd51f4890ca375df41a2c54 in an isolated checkout.
Required deployment correction: maintainers.json, CODEOWNERS and the embedded bootstrap policy differ from the canonical roster on .github/main. The canonical record still lists the departed maintainers; for integrations it also still names Qiang as backup. Running the existing detectDrift() against this PR reproduces maintainers.json differs from canonical roster and maintainer gate differs from reviewed template plus CODEOWNERS drift. The intended membership follows #60, but please land/link the central roster update and regenerate/recheck these snapshots before merging them. Otherwise the daily coverage audit reports drift and continues to route work using the retired roster. I am not asking to restore the departed accounts to the proposed policy.
Validation: 30 positive/negative cases executed against this PR's actual gate script, covering current-head approval, stale/dismissed/requested-changes reviews, bot/outsider rejection, trusted-base policy fallback, API errors, malformed policies and exact-bootstrap restrictions. The script matches the reviewed template when resolved with the proposed policy. Actionlint v1.7.12, diff checks and merge simulation against fetched main passed.
Separate hosted-check issue: the links job timed out on two existing git.elibot.ru URLs; its report contains zero other link errors. This is separate from the canonical-roster mismatch.
Requesting changes for the corrections above; I found no additional failure in the gate behavior exercised.
|
@carloshvp the central roster is agentrust-io/.github#61. |
carloshvp
left a comment
There was a problem hiding this comment.
Re-reviewed exact head f850e96a4ee5cbff3dd51f4890ca375df41a2c54. The earlier deployment blocker is resolved: agentrust-io/.github#61 is merged, and detectDrift() against canonical main d392977047dd6f8c6358a223de58e021568a9558 now reports no differences in maintainers.json, CODEOWNERS or the embedded gate. The PR head and complete file tree are unchanged from my earlier review.
Validation on this head: 40 positive/negative cases against the actual gate script, including rejection of departed maintainers and reviewer-only accounts, current-head independent human approval, stale/dismissed/requested-changes reviews, malformed policies, trusted-base fallback, API failures and restricted bootstrap behavior. Actionlint 1.7.12, diff checks, and a clean merge simulation against main 52c2c964d3403d3aa4836c3b90d1a1c8d538ce04 passed. The simulated merged snapshots also match the canonical roster. The previously reported hosted link check is now successful.
Approving this head; this supersedes my earlier changes request.
Moves this repository's review and merge coverage to community maintainers, as set out in the community handover. OPAQUE wound down on 2026-10-12, and its accounts are leaving the organization.
.github/maintainers.json, CODEOWNERS and the gate's bootstrap policy are regenerated frommaintainers/roster.jsonwithscripts/maintainer-roster.mjs, so the daily drift audit stays clean.🤖 Generated with Claude Code