Repository navigation
chore(docker): drop two dockerignore negations that do nothing - #964
Merged
Merged
Conversation
"!docker/debian.sources" names a file that isn't there: the Dockerfile copies debian.sources from the context root, and there is no docker/ dir. It also sat before "docker*", which re-excluded it, since Docker lets the last matching line win. No pattern excludes dist, so "!dist" had nothing to re-include. buildx gives the same build context, 1261 files, with or without them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
!distand!docker/debian.sourcesfrom.dockerignore. Neither one does anything:!docker/debian.sourcespoints to a file that doesn't exist. The Dockerfile runsCOPY debian.sources /etc/apt/sources.list.d/from the context root, and there is nodocker/directory. It also came beforedocker*, which excluded the file again: Docker uses the last matching line and also matches a path's parent directory. devenv's ignore-file sort had moved it there (fixed in fix(dotfiles): keep ignore negations after the patterns they override devenv#28).!dist: no pattern excludesdist, so there was nothing to bring back.dist/${CODEX_WHEEL}is still in the build context.Verification
I used buildx to export the build context (
FROM scratch/COPY . /ctx/) from a clean checkout with a dummy wheel indist/and a dummydocker/debian.sources:.dockerignoregive the same context, 1,261 files.debian.sources,dist/*.whl,pyproject.toml,uv.lock,frontend/package.json.docker/debian.sourcesis excluded under both versions.I didn't run the codex test suite, since the change only affects which files go into the Docker build context, and I checked that directly.
🤖 Generated with Claude Code