Repository navigation
Online tagging: toolbar Review button instead of an auto-opening dialog - #970
Merged
Merged
Conversation
Every tag-prompt socket message ran loadPrompts() with auto-open on, so a large tagging run reopened the Match Review dialog in every admin tab each time the daemon deferred a match. The passive cues were weak: an uncounted amber dot on the hamburger and a drawer item. - loadPrompts() only ever closes the dialog now; it opens from a click. - New OnlineTagReviewButton (tonal warning, "Review N", icon + count on phones) in the browser top toolbar and the admin title bar. - app.vue head() prefixes the document title with "(N) " for admins, so a background tab shows the count. - pendingComicCount moves into the store so the drawer label, the button and the title agree; the hamburger prompts dot is removed. The button is a plain v-btn, not ScaleButton: compact density on xs stacks with size="small" and measured 16px tall in the browser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the hamburger prompts dot gone, the reader had no passive cue for matches waiting; only the drawer item and the (tab-only) title prefix. Mount OnlineTagReviewButton after the reader toolbar's spacer, as in the browser toolbar. Nothing else in the reader top toolbar can shrink, so below 360px the button pushed the settings button off-screen (a three-digit reading order needs 360px with it, 302px without). Hide it under 360px; the drawer item still offers the review there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During a large online-tagging run, every deferred match reopened the Match Review dialog in every admin tab. Now the dialog never opens on its own. Admins get passive cues instead:
(3) Browse / Publishers, so a background tab shows waiting matches.N counts comics, not questions. A series-level prompt counts every issue it covers.
pendingComicCountnow lives in the store, so the drawer label, the button and the title always show the same number.Notes
v-btn, notScaleButton. On phones, compact density stacks withsize="small"and the button measured 16px tall.## v2.5.4section.pyproject.tomlis not bumped.Test plan
make lintmake test: vitest 984 passed, pytest 1662 passed + 1 known xfailreview-button.test.js.online-tag-store.test.jsadds no-auto-open,pendingComicCountandpendingTitlecases. The no-auto-open test fails when the old open branch is put back.(3) Browse / …and(3) Admin / …, and the prefix goes away when the queue empties🤖 Generated with Claude Code