fix(air): canonicalize type identities - #489
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeID-based internerVoidexclusively for Ard's unit typeDetails
This fixes the split identity domain between checker-derived and lowering-synthesized types that allowed one semantic
Result<Void, Error>to receive multiple AIRTypeIDs. Constructor validation remains strict; the producer now guarantees canonical identity instead of compensating with structural assignability.The checker-to-AIR boundary now preserves checked executable types, models non-returning expressions with a checker-only
Nevertype, and rejects unresolved call inference variables. Recursive nominal types use explicit lowerer-owned lifecycle state so incomplete metadata cannot escape finalized AIR.Testing
cd compiler && go test -p 1 ./... -count=1Fixes #466