Repository navigation
fix(parser): tolerate malformed match timestamps - #10
Merged
Merged
Conversation
Keep a malformed upstream startDate from aborting the entire score refresh, while preserving valid numeric timestamps and covering the behavior with tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Catch OSError for out-of-range timestamps, treat 0 and booleans as missing dates, and skip a single malformed match instead of dropping every match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
startDatevalues.Reproduction
A malformed upstream match such as this used to crash
_parse_match:{"startDate": "not-a-timestamp"}It raised:
The match now remains available with an empty date, while network and HTTP errors continue to be reported by the existing CLI/TUI error handling.
Verification
python -m pytest tests.py -q- 11 passedpython -m compileall -q criclive tests.pygit diff --checkThe repository has no
CONTRIBUTING.md; its README directs contributions through GitHub issues and pull requests.Fixes #1