Repository navigation
Refactor: Gamification coreLogic split into initial state and question logic - #294
Conversation
…n logic Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Visit the preview URL for this PR (updated for commit 93081c9): https://pyexplorer-cd32d--pr294-refactor-gamificatio-n45ae52c.web.app (expires Wed, 14 Oct 2026 11:12:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61 |
…n logic Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
This PR splits
src/utils/gamification/coreLogic.tsinto two smaller, single-responsibility files:initialState.tsandquestionLogic.ts.Why: The
coreLogic.tsfile handled two distinct domains: (1) Setting up the initial gamification structure and normalizing legacy object fields, and (2) applying complex point calculations, streak rules, and level evaluations whenever a question is completed. Splitting these follows the Single Responsibility Principle, making both testing and future modifications easier.Changes:
getInitialGamification,clampNumber,removePetField, andnormalizeGamificationForRulestosrc/utils/gamification/initialState.ts.recordQuestionLogictosrc/utils/gamification/questionLogic.ts.src/utils/gamification/coreLogic.ts.src/utils/gamificationState.tsto export the new modules instead of the old one.The changes were verified using tests, linting, and build commands successfully.
PR created automatically by Jules for task 8054663400108038416 started by @albertoivo