Repository navigation
Refactor: extract useWorldMapState from WorldMap - #304
albertoivo wants to merge 1 commit into
Conversation
Extracted the complex state management, story progression, and tutorial orchestration logic from `WorldMap.tsx` into a dedicated custom `useWorldMapState` hook. This significantly reduces the size of the component and cleanly separates the view layer from domain/orchestration logic, adhering to the Single Responsibility Principle. Fixed a synchronous setState call inside a useEffect along the way. Added an entry to the refactor journal. Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Visit the preview URL for this PR (updated for commit 8520f7c): https://pyexplorer-cd32d--pr304-refactor-worldmap-st-4ziiviyu.web.app (expires Sun, 01 Nov 2026 05:23:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61 |
Summary
Extracted
useWorldMapStatehook fromWorldMap.tsxto improve component size, readability, and adherence to SRP.Details
src/hooks/game/useWorldMapState.tsand moved ~180 lines of state management, saga logic, and modal orchestration into it.src/components/game/WorldMap.tsxto act purely as a presentational view layer.setStatein auseEffectinside the extracted logic by wrapping it in asetTimeout(..., 0)..agent/logs/refactor-journal.md.Verification
npx tsc -b --noEmitandnpm run lint.WorldMap.test.tsxand general functionality smoke tests.PR created automatically by Jules for task 3462104832274659156 started by @albertoivo