Repository navigation
Add session type annotation support. Part of alcounit/selenosis#84 - #14
Merged
Merged
Conversation
…reate behaviour. Part of alcounit/selenosis#84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show session type on browser cards and make VNC configurable
selenosis.io/session.typeselenium,playwright,devtools,mcpunknownotherwise); onlyseleniumbrowsers appear in the create-browser menusselenosis.io/session.vnc"true"enables; anything else or absent disablesseleniumbrowsers; new empty state No Selenium browsers configured.session.vncis resolved per browser version from BrowserConfig (per-version overtemplate; an explicit"false"in any config wins), overridden by the Browser CR annotation set through selenosis options. Config changes re-resolve running sessions.GET /api/v1/browsers/{id}/vncwithout upgrade is a VNC probe (204/503); the viewer checks it before the password prompt.vnc; unlabelled configs are grouped asunknowninsupportedBrowsers.NODE_OPTIONS=--no-experimental-webstorageso jsdom'slocalStorageworks on Node 25+.Breaking: VNC is off unless
selenosis.io/session.vnc: "true"; Selenium configs needselenosis.io/session.type: seleniumto stay in the create menu.Implements alcounit/selenosis#84