Skip to content

Add session type annotation support. Part of alcounit/selenosis#84 - #14

Merged
alcounit merged 1 commit into
mainfrom
feat/84-session-type-annotation
Oct 2, 2026
Merged

alcounit merged 1 commit into
mainfrom
feat/84-session-type-annotation

Conversation

@alcounit

@alcounit alcounit commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Show session type on browser cards and make VNC configurable

Annotation Values Effect
selenosis.io/session.type selenium, playwright, devtools, mcp Card label (unknown otherwise); only selenium browsers appear in the create-browser menus
selenosis.io/session.vnc "true" enables; anything else or absent disables Disabled CONNECT and a viewer message when VNC is not available
  • Session type label on every card, clickable as a filter.
  • Create-browser menus (Dashboard dropdown, Start Browser page) list only selenium browsers; new empty state No Selenium browsers configured.
  • session.vnc is resolved per browser version from BrowserConfig (per-version over template; an explicit "false" in any config wins), overridden by the Browser CR annotation set through selenosis options. Config changes re-resolve running sessions.
  • GET /api/v1/browsers/{id}/vnc without upgrade is a VNC probe (204 / 503); the viewer checks it before the password prompt.
  • Session JSON carries vnc; unlabelled configs are grouped as unknown in supportedBrowsers.
  • Frontend tests run with NODE_OPTIONS=--no-experimental-webstorage so jsdom's localStorage works on Node 25+.

Breaking: VNC is off unless selenosis.io/session.vnc: "true"; Selenium configs need selenosis.io/session.type: selenium to stay in the create menu.

Implements alcounit/selenosis#84

@alcounit
alcounit merged commit 14720f3 into main Oct 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant