Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dataclass field declared as
nickname: Optional[str] = Nonecurrently fails validation when its value isNone, including when the default is used. BothDataclassSchemaandcreate_dataclass_schemaraiseMultipleInvalid: expected strbecause annotation handling drops theNonealternative.Keep that alternative in the field validator so an omitted default or an explicit
Nonecan produce the expected dataclass instance. Fields without defaults still require a key, nonnullable fields still rejectNone, and additional constraints still apply.Six new cases fail before the change; all eight regression cases pass afterward. On Windows with Python 3.12, the normal suite passes 190 tests, and the existing 19 dataclass tests also pass when invoked explicitly. Black, isort, Flake8 and Mypy pass. The regressions are in the normally collected test file; other platforms and Python versions were not run locally.