Repository navigation
fix: report profile creation errors without panicking - #98
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
harpoon build --save --name missing/seccomp.jsoncannot create the output file, the error handler callsName()on the nil file returned byos.Createand panics. Use the requested profile name in the error so callers receive the wrapped filesystem error. Add a regression for a nonexistent output parent.Validation: the regression panics against the original
cmd/build.goand passes against the fixed file, using a temporary source-file harness with only a Cobra root binding to avoid initializing tracing commands. Safe unit packages (internal/archiver,internal/elfreader,internal/seccomputils,internal/syscallutils; analyzer has no tests) andgit diff --checkpass. Full command-package/build and privileged integration tests were not run: this environment's scope excludes loading eBPF, elevation and real-process tracing. Only synthetic temporary files were used.