Repository navigation
fix(pool): account for active workers when resizing - #146
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 95.74% 95.75% +0.01%
==========================================
Files 11 11
Lines 611 613 +2
==========================================
+ Hits 585 587 +2
Misses 23 23
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Resizing uses the previous concurrency limit to decide how many workers to start. Existing workers can still exceed that limit after a shrink. Raising it again then starts surplus workers that immediately retire. In a subpool with a full parent, those submissions can block Resize until running tasks finish.
Calculate available capacity from the current worker count under the existing mutex. The tests cover repeated resizing, partial retirement and growth above the original limit, for pools and subpools. A separate test checks that resizing returns while the parent is full.
Five regression cases fail against upstream. All seven new cases pass across 50 runs with the race detector.
make test-cipasses on Go 1.25.8.make coveragepasses on Go 1.21.13.go build ./...,go vet ./...and formatting checks pass.