Skip to content

Introduce the MCP servers as allthings - #181

Merged
esthor merged 1 commit into
mainfrom
esthor/mcp-allthings
Oct 7, 2026
Merged

esthor merged 1 commit into
mainfrom
esthor/mcp-allthings

Conversation

@esthor

@esthor esthor commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

preview: ready coderabbit: approved findings: none checks: passing merge: ready

Preview · Change Stack · Checks · Files: +27 −18 in 8 files

What

The MCP servers now introduce themselves under the new name. Tool names and the data contract don't change.

  • The public server. In initialize, serverInfo.name changes from all-things-web to allthings.
    • That covers the Worker (web/src/mcp/server.ts) and the app (app/src/app/mcp/route.ts), which still serves allthingsweb.dev. The parity tests hold the two equal, so both change together.
    • The tests' copy of the app (web/tests/support/app.ts) changes with them.
  • Tool text, in both servers. "All Things Web" becomes "all things" in:
    • the list_events, get_event and list_speakers descriptions
    • get_community's title ("About all things") and description
    • the outage message ("all things events are temporarily unavailable…")
  • The organizers' local server (app/scripts/mcp-server.ts) changes from allthingsweb-scripts to allthings-scripts. Nothing references the old name.
  • Unchanged:
    • Tool names (list_events, get_event, list_speakers, get_community), input and output schemas, and every tool's data.
    • get_community's own name ("All Things Web") and its description. Both are copy in the public contract that the app, the Worker and the CLI's fixtures share. Rewriting them is a content change for its own PR, ideally with Erik's wording.
    • Package names were already allthings-*.
  • Tests. The Worker test now pins serverInfo.name to allthings, and fails if a tool's title or description mentions "All Things Web".

Verified

  • web: check, typecheck and all 968 tests pass, including MCP parity with the app.
  • app: the MCP tests pass (8).
  • cli: all 26 tests pass.
  • core: all 2,035 tests pass.
  • Repo lint: passes.

Summary by CodeRabbit

  • Updates
    • Updated the MCP server name and user-facing tool descriptions and error messages to use “all things” branding. Tool functionality remains unchanged.

The public MCP server (the Worker and, for parity, the app) now
introduces itself as allthings, and its tool titles, descriptions and
outage message say all things. Tool names, schemas and get_community's
data are unchanged. The organizers' local MCP server becomes
allthings-scripts.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: allthingsweb-dev/allthingsweb/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 330e220f-e9ab-49dd-9454-4626465d5f14
📥 Commits

Reviewing files that changed from the base of the PR and between ed4555a and ca54226.

📒 Files selected for processing (8)
  • app/scripts/mcp-server.ts
  • app/src/app/mcp/route.ts
  • app/src/lib/mcp/tools.ts
  • cli/tests/client.test.ts
  • web/src/mcp/server.ts
  • web/src/mcp/tools.ts
  • web/tests/support/app.ts
  • web/tests/worker.test.ts

Limit details: You’ve used the included review currently available. Your 105 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: 🧱 Core
  • GitHub Check: 🌐 Web
  • GitHub Check: 🧪 Tests
  • GitHub Check: 🚀 Deploy
  • GitHub Check: 🧹 Lint

📝 Walkthrough

Walkthrough

MCP server names, tool titles, descriptions, and error messages now use updated “allthings” or “all things” wording. Related test expectations were updated.

Changes

MCP naming

Layer / File(s) Summary
Server names and initialization checks
app/scripts/mcp-server.ts, app/src/app/mcp/route.ts, web/src/mcp/server.ts, web/tests/support/app.ts, web/tests/worker.test.ts
MCP server names change to allthings or allthings-scripts. Web test setup and initialization assertions use the updated name.
Tool descriptions and error messages
app/src/lib/mcp/tools.ts, web/src/mcp/tools.ts, cli/tests/client.test.ts, web/tests/worker.test.ts
Tool titles, descriptions, and temporary-unavailability messages replace “All Things Web” with “all things.” Related test expectations are updated.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to ca542

The MCP servers and tool text will use the intended allthings branding; no actionable merge-blocking risk is evident in the supplied change context.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to ca542

The changes are limited to advertised server names, descriptive wording, and test expectations. The reviewed changes do not expand tool capabilities, data access, or permissions. No security findings remain.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The verified change affects metadata presented to existing MCP clients. It does not add an attacker-controlled input, new callable tool, privileged sink, or additional data-access path in the inspected implementations.

Trust Boundaries and Controls

  • observed — Public-tool validation and callback dispatch remain unchanged. Data-source failures retain the existing reporting or logging path and generic client-facing failure response; only the branding in that response changes.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 8 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: the MCP servers now use the name “allthings.”
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.


Comment @coderabbitai help to get the list of available commands.

@esthor
esthor merged commit 8e21836 into main Oct 7, 2026
15 checks passed
@esthor
esthor deleted the esthor/mcp-allthings branch October 7, 2026 02:10

This branch was successfully deployed

1 active deployment
preview — ca54226c Deployed Oct 7, 2026 by esthor via 🚀 Deploy #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant