Skip to content

Remove the stdio MCP's administrator tools and their scripts - #213

Merged
esthor merged 1 commit into
mainfrom
remove-admin-list-tools
Oct 7, 2026
Merged

esthor merged 1 commit into
mainfrom
remove-admin-list-tools

Conversation

@esthor

@esthor esthor commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

preview: ready coderabbit: approved findings: none checks: passing merge: ready

Preview · Change Stack · Checks · Files: +0 −224 in 5 files

What

Step 10 of the admin audit: the stdio admin MCP server (app/scripts/mcp-server.ts) drops its three administrator tools. They managed who could use the admin, and the admin and its sign-in are gone (#207, #212).

  • Tools removed: add_user_to_admins, remove_user_from_admins and list_admins, with their definitions and handlers.
  • Functions removed: addUserToAdmins, removeUserFromAdmins and listAdmins in app/scripts/functions.ts.
  • Scripts removed: app/scripts/add-user-to-admins.ts, remove-user-from-admins.ts and list-admins.ts.

Every other tool stays: photos, posts, planning, Luma, social and the rest. The schema keeps the administrators table; dropping it would be a migration, and none is part of this.

Why

Erik: remove the old admin now, since it's dead weight while we refactor. Nothing reads administrators any more, so these tools would only manage a list nothing checks.

Verify

cd app && bun run typecheck:scripts && bun run typecheck && bun test   # 161 pass

I started the stdio server and sent initialize and tools/list. It answers with 51 tools: none is an administrator tool, and remove_event_photo is still there.

The old app's Next build doesn't include app/scripts, so the Vercel preview serves exactly what main serves.

Summary by CodeRabbit

  • Changes
    • Administrator management options are no longer available through the app’s assistant tools. This includes adding or removing administrators and viewing the administrator list.
    • Standalone commands for adding, removing, and listing administrators have also been removed. Other assistant tools remain available.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: allthingsweb-dev/allthingsweb/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d7230208-8ead-4005-b017-8f1eb86934ec
📥 Commits

Reviewing files that changed from the base of the PR and between 37a04dd and 1f88750.

📒 Files selected for processing (5)
  • app/scripts/add-user-to-admins.ts
  • app/scripts/functions.ts
  • app/scripts/list-admins.ts
  • app/scripts/mcp-server.ts
  • app/scripts/remove-user-from-admins.ts
💤 Files with no reviewable changes (5)
  • app/scripts/remove-user-from-admins.ts
  • app/scripts/add-user-to-admins.ts
  • app/scripts/list-admins.ts
  • app/scripts/functions.ts
  • app/scripts/mcp-server.ts

Limit details: You’ve used the included review currently available. Your 112 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: 🧹 Lint
  • GitHub Check: 🧪 Tests
  • GitHub Check: 🚀 Deploy

📝 Walkthrough

Walkthrough

The pull request removes the administrator add, remove, and list functions, their standalone scripts, and the corresponding MCP tool definitions and execution cases.

Changes

Administrator management removal

Layer / File(s) Summary
Remove administrator operations
app/scripts/functions.ts, app/scripts/add-user-to-admins.ts, app/scripts/remove-user-from-admins.ts, app/scripts/list-admins.ts
The administrator add, remove, and list functions and the scripts that called them are removed.
Remove MCP administrator tools
app/scripts/mcp-server.ts
The server no longer imports or exposes the administrator tools, or handles their execution cases.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1f887

No repository-controlled workflow appears to depend on the removed administrator tools. The change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the stdio MCP administrator tools and their associated scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@esthor
esthor merged commit 5514bec into main Oct 7, 2026
12 checks passed
@esthor
esthor deleted the remove-admin-list-tools branch October 7, 2026 18:18

This branch was successfully deployed

1 active deployment
preview — 1f887507 Deployed Oct 7, 2026 by esthor via 🚀 Deploy #521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant