Repository navigation
Remove the stdio MCP's administrator tools and their scripts - #213
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
Limit details: You’ve used the included review currently available. Your 112 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
📝 WalkthroughWalkthroughThe pull request removes the administrator add, remove, and list functions, their standalone scripts, and the corresponding MCP tool definitions and execution cases. ChangesAdministrator management removal
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to No repository-controlled workflow appears to depend on the removed administrator tools. The change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
✨ Simplify code
Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview · Change Stack · Checks · Files: +0 −224 in 5 files
What
Step 10 of the admin audit: the stdio admin MCP server (
app/scripts/mcp-server.ts) drops its three administrator tools. They managed who could use the admin, and the admin and its sign-in are gone (#207, #212).add_user_to_admins,remove_user_from_adminsandlist_admins, with their definitions and handlers.addUserToAdmins,removeUserFromAdminsandlistAdminsinapp/scripts/functions.ts.app/scripts/add-user-to-admins.ts,remove-user-from-admins.tsandlist-admins.ts.Every other tool stays: photos, posts, planning, Luma, social and the rest. The schema keeps the
administratorstable; dropping it would be a migration, and none is part of this.Why
Erik: remove the old admin now, since it's dead weight while we refactor. Nothing reads
administratorsany more, so these tools would only manage a list nothing checks.Verify
I started the stdio server and sent
initializeandtools/list. It answers with 51 tools: none is an administrator tool, andremove_event_photois still there.The old app's Next build doesn't include
app/scripts, so the Vercel preview serves exactly what main serves.Summary by CodeRabbit