Repository navigation
Conversation
Role skills, task-state references and contract-test models stated a literal three-attempt cap that no profile setting could change. Keep the new-evidence retry rule and round budgets; a recorded correction allowance is now the only cap. Refs #211
4 tasks
Resolve conflicts in favor of main: PR #217 (2.0.0) already removed the skill-text caps and MAX_CORRECTIONS. Keep the recovery test-model change, the last remaining hard-coded correction cap, and reword the changelog.
1wgrumph
pushed a commit
that referenced
this pull request
Oct 21, 2026
The recovery contract-test model still forced OWNER_DECISION_REQUIRED on a third correction and rejected a fourth. Skill-text caps were removed in 2.0.0 (#217); task-state.md now caps corrections only by an owner-supplied allowance. A correction with new evidence now returns READY. Refs #211. Supersedes #212.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the last hard-coded correction cap. Refs #211.
mainalready removed the skill-text caps ("at most three attempts", "third failed correction",MAX_CORRECTIONS = 3) in 2.0.0 (#217). After mergingmain, this PR's remaining change is the recovery contract-test model:test/recovery.test.mjs:applyCorrectionno longer forcesOWNER_DECISION_REQUIREDon a 3rd correction or rejects a 4th. A correction with new evidence returnsREADY; the test proves the 3rd and 4th do. The counter is a record, not a limit, matchingtask-state.mdonmain(only an owner-supplied allowance caps corrections).CHANGELOG.md: Unreleased entry.Issue #211 stays open for its profile-driven configurable-limit item.
Verification
node --test test/*.test.mjs: 966 pass, 0 failpython3 test/schema-validation.py: passed=319 failed=0node --test test/native/codex-hook-discovery.test.mjs: 3 pass, 0 fail🤖 Generated with Claude Code
https://claude.ai/code/session_012NmRjMTF9dGTPtnTZ8JLN5