Repository navigation
Serve the self-hosting landing page at /self-host - #12
Merged
Merged
Conversation
chesspirit.app's reverse proxy serves its own home page at /, so the in-app landing page only appeared after a client-side jump back from /try. Serve it at /self-host, link it from the public header, make the signed-out logo a full page load to /, and send unknown signed-out paths to /login again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BANAeunr22J7BzgopZzgWs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On chesspirit.app,
/showed the existing static home page, but the new landing page appeared after visiting/tryand clicking back to the home page.Cause. The reverse proxy on the server serves a static page at
/. Every other path goes to the app, so the in-app landing page was only reachable by a client-side jump to/.Fix. Keep both pages:
/stays the static page, for players./self-hostis the in-app landing page, for people who want to run their own copy.Changes:
/self-hostserves the landing page for signed-out and signed-in visitors./tryand shared reviews)./, so the proxy's page shows. When signed in, the logo still goes to the app's Home./loginagain instead of the landing page./self-host; the README links it.Tests.
npm run typecheck, 477 tests and the build pass. Browser check:/self-hostrenders, the header link works from/try, the logo ishref="/", and/nopegoes to/login.🤖 Generated with Claude Code
https://claude.ai/code/session_01BANAeunr22J7BzgopZzgWs
Generated by Claude Code