Repository navigation
Add a private player directory and challenge by username - #8
Merged
Merged
Conversation
Every account could see every other account's name, record, ratings, recent games and presence. That is right for a household and a leak on a server open to strangers. With Admin → System → Private player directory on, a user sees only themselves and the people they have played (a shared PvP game or an accepted challenge). The players list, profiles, the lobby user list, presence updates and challenge-by-id all follow that rule; admins still see everyone. A profile the viewer may not see answers 404, the same as a missing id. Off by default. To reach someone new, POST /api/challenges now also takes to_username (exact match), and the vs Friend tab shows a username field when the directory is private. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019nmbXPWqoaKiE7eMTHacLQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every account could see every other account's name, record, ratings, recent games and presence. That is right for a household and a leak on a server open to strangers.
With Admin → System → Private player directory on, a user sees only themselves and the people they have played (a shared PvP game or an accepted challenge). The players list, profiles, the lobby user list, presence updates and challenge-by-id all follow that rule; admins still see everyone. A profile the viewer may not see answers 404, the same as a missing id. Off by default.
To reach someone new, POST /api/challenges now also takes to_username (exact match), and the vs Friend tab shows a username field when the directory is private.
Claude-Session: https://claude.ai/code/session_019nmbXPWqoaKiE7eMTHacLQ
What
Test plan
npm run typecheckpassesnpm testpassesnpm run buildpassesnpm run test:e2e,test:resume,test:ui,test:resume-uipassChangelog