De-sprawl: retire Sutta Studio shims, single Gemini SDK, delete dead code

[anantham]

Owner-approved simplification pass from a review of open issues and the DESPRAWL roadmap. It is mostly behavior-preserving; the three Gemini request/response changes listed under "Behavior changes" are the exceptions.

Changes

1. Sutta Studio shims retired (CONSOLIDATION Phase 4, partial)

• services/compiler/*, services/sutta-studio/prompts/skeleton.ts, benchmark scripts and tests import services/sutta-studio/{llm,prompts,schemas,utils,passes} directly.
• Deleted the six pure re-export shims: services/suttaStudioPass{Prompts,Runners}.ts, services/compiler/{llm,prompts,schemas,utils}.ts.
• schemas-canonical.test.ts: the cross-location identity check becomes a canonical-export check. The wordRange/refrainId guards are unchanged.
• services/compiler/{index,skeleton}.ts stay; retiring them depends on Phase 2d and decision D2.

2. Single Gemini SDK (@google/genai)

• GeminiAdapter (translate + chatJSON), the Gemini image branch in imageService.ts and the Gemini response schemas move off the legacy @google/generative-ai.
• Abort signals travel in config.abortSignal. Cancellation was checked with a loopback HTTP test during review.
• Both adapter entry points share responseTextOrThrow, which keeps the legacy SDK's rule: text from a candidate whose finishReason is SAFETY, RECITATION or LANGUAGE is rejected. The new SDK's text getter would otherwise return it. Review found this in 0207fdb; c174b18 fixes it, and the regression tests fail without the fix.

3. Dead code and dependencies

• Deleted migrateFromLocalStorage, isMigrationCompleted and resetMigrationState, which had zero importers (DESPRAWL T2.4b).
• Deleted services/audio/storage/{cache,opfs}.ts. They had zero importers and were committed with literal \n escapes, so they needed exclusions in tsconfig.json, vitest.config.ts and eslint.config.mjs. Those exclusions are removed, along with a stale pinning.ts entry.
• services/audio/storage/utils.ts stays because AudioPlayer.tsx uses formatDuration.
• Deleted public/debug-chapter2.js, a one-off console diagnostic that was shipped to every user.
• Dropped @google/generative-ai, @types/jszip (jszip ships its own types) and ts-prune (unused).

Behavior changes (all Gemini; confirmed in review)

1. Empty responses now name the block or finish reason, e.g. Empty response from Gemini API (SAFETY), and blocked candidates raise Gemini response blocked (<reason>).
2. additionalProperties is stripped from chatJSON schemas by the new SDK's processJsonSchema. This includes Sutta Studio's string-valued ripples map constraint. The difference in the request payload is proven; the effect on Google's output is untested.
3. Gemini 2.0 image-generation models: responseModalities moves from the request's top level into generationConfig, which is the location Google's API reference documents. This is likely a correction, but it is still a change.

Verification

• Base vs PR on Node 24.21.0, run by an independent reviewer: install, typecheck, lint, build and integrity checks pass on both. Tests: 9,562 passed on base and 9,563 on the PR at 0207fdb, with 347 skipped each. No existing test changed status.
• After the fix (c174b18), run in a Node 22 container: typecheck passes, lint has 0 errors, the build passes, and 9,567 tests pass (5 are new). The one failure, in indrasNetImageProvider.test.ts, is specific to this Node 22 environment; it passes on Node 24.
• Not verified: live Gemini calls. Worth one real translation, one Sutta Studio compile on Gemini (because of behavior change 2), and one Gemini image generation before merge.

Follow-ups (not in this PR)

• The hand-maintained Gemini schema variants in translationResponseSchema.ts (~130 lines) and the provider branch in translationService.ts could be dropped, because the new SDK accepts the JSON schemas directly. This needs a live test first.
• If the ripples map constraint matters to Gemini output, pass it through responseJsonSchema instead of responseSchema.
• Seven now-unused exports in services/audio/storage/utils.ts.

🤖 Generated with Claude Code

https://claude.ai/code/session_011d1MbSabs9nA9d9w8pxP1W

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
lexicon-forge	Ready	Preview	Sep 24, 2026 1:41pm UTC