Skip to content

Keep editing fields visible above the keyboard - #119

Merged
andre487 merged 5 commits into
mainfrom
review/keyboard-overlap
Oct 22, 2026
Merged

andre487 merged 5 commits into
mainfrom
review/keyboard-overlap

Conversation

@andre487

@andre487 andre487 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Opening the keyboard could cover split-tunneling search and leave only a narrow strip of editable content in short windows. Reserve bottom-bar IME space, reveal focused fields when validation changes their height, and move status notices into the scrolling form while temporarily hiding the app bar in short windows. Observe window insets once above navigation so screen transitions cannot detach the next screen’s observer.

Add isolated local real-keyboard checks and EN/RU instructions. Stabilize the existing device checks: avoid reselecting the current Downloads directory; prepare a validated default Wi-Fi network and verify the private SSH fixture banner before VPN scenarios. Public captive-portal probes are disabled only on disposable emulators. API 35 waits for a completed reconnect and a new network; API 26 retains its connection because its svc wifi client exits with 137. Preflight failures preserve network diagnostics and stop the suite. No test retries were added.

Validation:

  • CI for 4f0dd23 passed: Python and both API 26/API 35 integration suites, including published JUnit checks. Unchanged suites retain the existing scope policy.
  • 75 Python tests and style checks passed locally. Complete network bootstrap and the emulator-to-host banner probe passed on both local emulators.
  • 346 JVM tests, Android lint, debug and release builds passed locally; the latest local debug build passed too.
  • 45/45 local real-IME checks passed across API 26/API 35 emulators and CPH2551 (API 36, Yandex Keyboard): five fields in portrait RU, landscape EN and landscape RU with 200% fonts, including IME dismissal and navigation restoration.
  • GM1910 (API 31, Gboard): five portrait checks passed. Its landscape keyboard is floating and supplies no bottom IME inset; docked landscape checks remain pending the user’s choice about temporarily changing that mode.
  • Real system-provider export/import passed locally on API 26 and API 35. Isolated test APKs were removed and phone settings were verified unchanged.

Keep this PR draft while the GM1910 landscape coverage remains unresolved.

@andre487
andre487 marked this pull request as ready for review October 22, 2026 17:04
@andre487
andre487 merged commit 1ed8635 into main Oct 22, 2026
14 checks passed
@andre487
andre487 deleted the review/keyboard-overlap branch October 22, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant