Repository navigation
Fix cancellation of SSH jump handshakes - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an SSH jump server stops processing traffic during the destination handshake, cancelling the connection or stopping the VPN can wait forever for an SSH channel close acknowledgement. The blocked handshake holds the dialer mutex and prevents native teardown and subsequent VPN starts.
Make the destination connection close its dedicated jump TCP transport, which unblocks the handshake without cooperation from the server. Add a local encrypted SSH regression test that waits until the destination handshake starts, stalls the jump peer, and verifies both context cancellation and dialer shutdown. Both scenarios failed before the fix.
Validation:
bundle exec fastlane android native_tests(race detector); targeted SSH cancellation and rotation tests;git diff --check.APK artifacts
Built from commit
d315748eby CI run #450.Artifacts expire after 14 days. Neither APK uses the MegaProxy release key.