Repository navigation
fix: handle Android SDK codenames in permission loading - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix APK parsing failures when
targetSdkVersionor related SDK values are Android preview codenames rather than numeric API levels.Problem
apk-parserpasses SDK codename strings such asQto permission resource loading, where they are converted usingint(). This raisesValueErrorand prevents the APK from being parsed successfully.Changes
Verification
TestDPC_6000.apkwas verified after the fix.Scope
The change is limited to SDK-level resolution and the affected permission-loading path. Existing permission resource selection behavior is preserved.
Fixes #3