Skip to content

Fix Kotlin namespace parity checklist #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tolyo merged 6 commits into from
Oct 27, 2026
Merged

Fix Kotlin namespace parity checklist #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f92783
Fix Kotlin namespace parity coverage
tolyo Oct 27, 2026
0b2b12b
Fix Kotlin namespace parity coverage
tolyo Oct 27, 2026
9880ee3
Record Kotlin member parity decisions
tolyo Oct 27, 2026
2f1e66d
Sort Kotlin type overrides
tolyo Oct 27, 2026
2d36cd8
Preserve generated members for manual parity coverage
tolyo Oct 27, 2026
e2c9675
Preserve generated members for manual parity coverage
tolyo Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions integrations/kotlin/NG_NAMESPACE_PARITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ part of the Kotlin public facade.
| `LinkFn` | generated |
| `Model` | generated |
| `ModelChange` | generated |
| `ModelValidationContext` | generated |
| `ModelParser` | manual |
| `ModelFormatter` | manual |
| `ModelValidators` | manual |
| `AsyncModelValidators` | manual |
| `ModelRestoreOptions` | generated |
| `ModelSyncFailureMode` | generated |
| `ModelSyncOptions` | generated |
Expand Down Expand Up @@ -174,6 +179,7 @@ part of the Kotlin public facade.
| `StreamService` | generated |
| `TemplateCacheService` | generated |
| `TemplateRequestService` | generated |
| `TemplateRequestOptions` | manual |
| `TransitionsService` | generated |
| `WebComponentService` | generated |
| `WebSocketService` | generated |
Expand Down
13 changes: 12 additions & 1 deletion integrations/kotlin/src/jsTest/kotlin/angular/ts/AngularTsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,24 @@ class AngularTsTest {
val parser: ModelParser<Double, String> = { text -> text.toDoubleOrNull() }
control.addParser(parser)
assertTrue(control.parsers[0]("invalid").asDynamic() === js("undefined"))
control.formatters = arrayOf({ value: Double? -> value?.toString() ?: "" })
val formatter: ModelFormatter<Double, String> = { value -> value?.toString() ?: "" }
control.formatters = arrayOf(formatter)
assertEquals("", control.formatters[0](null))
control.validators["positive"] = { value, text -> (value ?: 0.0) > 0 && text != "" }
assertEquals(true, control.validators["positive"]?.invoke(12.0, "12"))
assertEquals(24.0, control.parsers[0]("24"))
control.setViewValue("24")
assertEquals("24", control.viewValue)
val abort = js("new AbortController()")
val context = js("({})").unsafeCast<ModelValidationContext>()
context.signal = abort.signal
var validationSignal: dynamic = null
control.asyncValidators["remote"] = { value, text, validation ->
validationSignal = validation.signal
Promise.resolve(value != null && text != null)
}
assertNotNull(control.asyncValidators["remote"]).invoke(12.0, "12", context)
assertSame(abort.signal, validationSignal)
var captured: dynamic = null
val request: dynamic = { _: String, options: dynamic -> captured = options.signal }
val templateRequest = TemplateRequestService(request.unsafeCast<angular.ts.generated.TemplateRequestService>())
Expand Down
4 changes: 3 additions & 1 deletion integrations/kotlin/tool/check_ng_namespace_members.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const stalePatterns = [
...staleObjectKeys("types", overrides.types, collectReferencedTypeNames()),
...staleListPatterns("callableProperties", overrides.callableProperties),
...staleListPatterns("manual", overrides.manual),
...staleListPatterns("manualCoverage", overrides.manualCoverage),
...staleListPatterns("unsupported", overrides.unsupported),
];
const orderingProblems = [
Expand All @@ -38,6 +39,7 @@ const orderingProblems = [
...objectOrderingProblems("types", overrides.types),
...listOrderingProblems("callableProperties", overrides.callableProperties),
...listOrderingProblems("manual", overrides.manual),
...listOrderingProblems("manualCoverage", overrides.manualCoverage),
...listOrderingProblems("unsupported", overrides.unsupported),
];
const missingCoverage = uncoveredImplementedMembers();
Expand Down Expand Up @@ -189,7 +191,7 @@ function isRepoTypesNode(node) {
}

function uncoveredImplementedMembers() {
const manual = new Set(overrides.manual ?? []);
const manual = new Set([...(overrides.manual ?? []), ...(overrides.manualCoverage ?? [])]);
const unsupported = new Set(overrides.unsupported ?? []);
const missing = [];

Expand Down
11 changes: 8 additions & 3 deletions integrations/kotlin/tool/generator-overrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
{
"callableProperties": [],
"manual": [],
"manualCoverage": [
"ModelFormatter.call",
"ModelParser.call",
"TemplateRequestOptions.signal"
],
"propertyTypes": {
"GeolocationValue.altitude": "Double?",
"GeolocationValue.altitudeAccuracy": "Double?",
Expand All @@ -19,11 +24,11 @@
"Element": "org.w3c.dom.Element",
"Event": "org.w3c.dom.events.Event",
"HTMLElement": "org.w3c.dom.HTMLElement",
"ModelValidationContext": "ModelValidationContext",
"Node": "org.w3c.dom.Node",
"TemplateRequestOptions": "TemplateRequestOptions",
"TModel": "TModel",
"TView": "TView",
"ModelValidationContext": "ModelValidationContext",
"TemplateRequestOptions": "TemplateRequestOptions"
"TView": "TView"
},
"unsupported": []
}
Loading