Skip to content

Release build resources early in non-watch mode and prevent process hang on unhandled error #33715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 3 commits into from
Closed

Release build resources early in non-watch mode and prevent process hang on unhandled error #33715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
902e8ea
perf(@angular/build): release build resources early in non-watch mode
alan-agius4 Jul 31, 2026
c0cf4a5
fix(@angular/build): prevent build process hang on unhandled error
alan-agius4 Jul 31, 2026
e934d32
fixup! fix(@angular/build): prevent build process hang on unhandled e…
alan-agius4 Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/angular/build/src/builders/application/build-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,16 @@ export async function* runEsBuildBuildAction(
const withProgress: typeof withSpinner = progress ? withSpinner : withNoProgress;

// Initial build
let result: ExecutionResult;
let result: ExecutionResult | undefined;
try {
// Perform the build action
result = await withProgress('Building...', () => action());

// Log all diagnostic (error/warning/logs) messages
await logMessages(logger, result, colors, jsonLogs);
} finally {
// Ensure Sass workers are shutdown if not watching
if (!watch) {
// Ensure Sass workers are shutdown if not watching or if the initial build failed
if (!watch || !result) {
shutdownSassWorkerPool();
}
}
Expand Down
Loading