build(deps): bump compileSdk to 37 - #21679
Draft
david-allison wants to merge 5 commits into
Draft
Conversation
Prep for compileSdk 37: `SHOW_IMPLICIT` is deprecated in API 37. The flag is a no-op from Android 16, so drop it on API 36+ Part of 21672 Assisted-by: Claude Fable 5
david-allison
force-pushed
the
21672-compile-sdk-37
branch
from
September 1, 2026 00:46
c2aa7b7 to
32c447e
Compare
Simplifies call sites Part of 21672 Assisted-by: Claude Fable 5
Prep for compileSdk 37: its annotation metadata declares an empty IntDef for the platform `InsetsType` typedef, so lint reports a `WrongConstant` false positive on `WindowInsetsController.hide`. The androidx annotations are unaffected Part of 21672 Assisted-by: Claude Fable 5
david-allison
force-pushed
the
21672-compile-sdk-37
branch
from
September 1, 2026 00:47
32c447e to
11bd767
Compare
david-allison
marked this pull request as draft
September 1, 2026 01:29
david-allison
force-pushed
the
21672-compile-sdk-37
branch
from
September 1, 2026 01:41
11bd767 to
ad6fee6
Compare
Robolectric 4.16.1 supports a max of SDK 36 Assisted-by: Claude Fable 5
SDK 37 is the first release under 'major.minor' SDK versioning: the platform ships as `android-37.0`, so `compileSdkMinor` must be set for the target to resolve Fixes 21672 Assisted-by: Claude Fable 5
david-allison
force-pushed
the
21672-compile-sdk-37
branch
from
September 1, 2026 08:44
ad6fee6 to
eb6ad1d
Compare
david-allison
marked this pull request as ready for review
September 1, 2026 09:24
Member
Author
|
Blocked on
-- https://github.com/ankidroid/Anki-Android/actions/runs/33323535173/job/99289560127?pr=21551 |
david-allison
marked this pull request as draft
September 4, 2026 19:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Fable 5
Purpose / Description
Standard
compileSdkbump - easy oneFixes
Approach
Firstly perform some refactorings:
showSoftInput-SHOW_IMPLICITis deprecated, so move calls which use this to CompatWrongConstantsin WindowInsetsController.hideThen, we have a trivial version bump, with
compileSdkMinorrequired. See LearningHow Has This Been Tested?
Learning (optional, can help others)
No good link on
compileSdkMinor: https://android-developers.googleblog.com/2024/10/android-sdk-release-update.htmlChecklist