Skip to content

test: extend 'ReviewRemindersScreenshotTest' - #21768

Merged
ericli3690 merged 8 commits into
ankidroid:mainfrom
david-allison:21753-1
Sep 12, 2026
Merged

test: extend 'ReviewRemindersScreenshotTest'#21768
ericli3690 merged 8 commits into
ankidroid:mainfrom
david-allison:21753-1

Conversation

@david-allison

@david-allison david-allison commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Note

Assisted-by: GPT-6

Fixes

Approach

  • Should cover both review reminders present on the screen and not present (empty ScheduleReminders view)
  • (maybe) The permission-requesting bottom sheet
  • What a review reminder looks like when the associated deck is deleted

How Has This Been Tested?

These are tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • ReminderTroubleshootingScreenshotTest: 3 changes
  • ReviewRemindersScreenshotTest: 12 changes
All 15 changed screenshots

ReminderTroubleshootingScreenshotTest

  • allChecksPassing_compare.png
  • checksWithWarnings_compare.png
  • failedChecks_compare.png

ReviewRemindersScreenshotTest

  • deletedDeckReminders_compare.png
  • globalAndDeckReminders_enabledAndDisabled_compare.png
  • legacyNotificationPermissionBottomSheet_compare.png
  • notificationPermissionBottomSheet_compare.png
  • settingsHostTablet_scheduleReminders_compare.png
  • settingsHost_landscapeCutout_collapsed_compare.png
  • settingsHost_landscapeCutout_compare.png
  • settingsHost_scheduleReminders_compare.png
  • settingsHost_scheduleReminders_scrolled_compare.png
  • standaloneActivityHost_scheduleReminders_compare.png
  • standaloneActivityHost_systemBars_compare.png
  • standaloneActivityHost_systemBars_scrolledToEnd_compare.png

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 6, 2026
@david-allison

This comment was marked as resolved.

Sign in to view
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Sep 6, 2026
ericli3690
ericli3690 approved these changes Sep 8, 2026
View reviewed changes

@ericli3690 ericli3690 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking this on, feel free to ping me on the further PRs when you create the rest

Comment thread AnkiDroid/src/test/java/com/ichi2/anki/reviewreminders/ReviewRemindersScreenshotTest.kt
Comment thread AnkiDroid/src/test/java/com/ichi2/anki/reviewreminders/ReviewRemindersScreenshotTest.kt
Comment thread AnkiDroid/src/test/java/com/ichi2/anki/reviewreminders/ReviewRemindersScreenshotTest.kt Outdated
}
}

private fun captureNotificationPermissionSheet(name: String) {

@ericli3690 ericli3690 Sep 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps a more descriptive name and contract would be createReviewReminderThen(block: () -> Unit)

@ericli3690 ericli3690 added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 8, 2026
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Sep 8, 2026
@david-allison

david-allison commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

@ericli3690 minor rework, feel it could do with a re-review before I self-merge

ericli3690
ericli3690 approved these changes Sep 11, 2026
View reviewed changes

@ericli3690 ericli3690 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, please deconflict and then it's good to go!

@ericli3690 ericli3690 added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 11, 2026
@david-allison
test(reminders): add withScheduleRemindersFragment
e485fcb 
Part of 21753

Assisted-by: Claude Fable 5.1
@david-allison
test(reminders): use view binding
95d5803 
Part of 21753

Assisted-by: Claude Fable 5.1
@david-allison
test(reminders): clear reminders between tests
85e8cf3 
Part of 21753

Assisted-by: GPT-6
@david-allison
test(reminders): screenshot enabled and disabled reminders
2cd257b 
Cover global and deck-specific reminders in the populated schedule view.

Part of 21753

Assisted-by: GPT-6
@david-allison
test(reminders): screenshot reminders for a deleted deck
fe7f946 
Cover enabled and disabled reminders after their associated deck is removed.

Part of 21753

Assisted-by: GPT-6
@david-allison
test(reminders): screenshot notification permission bottom sheet
cc20a4f 
Capture the permission request shown after saving a first reminder.

Part of 21753

Assisted-by: GPT-6
@david-allison
test(reminders): screenshot legacy notification permission sheet
ec28775 
Capture the legacy permission content directly on the suite's SDK to avoid loading the native backend in another classloader.

Part of 21753

Assisted-by: GPT-6
@david-allison
test(reminders): better scrolled screenshot
9e34bcb 
Overflow the list, so the toolbar collapses and
we scroll to the bottom.

Part of 21753

Assisted-by: Claude Fable 5.1
ericli3690
ericli3690 approved these changes Sep 12, 2026
View reviewed changes

@ericli3690 ericli3690 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging!

@ericli3690
ericli3690 added this pull request to the merge queue Sep 12, 2026
Merged via the queue into ankidroid:main with commit 943dfed Sep 12, 2026
22 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Sep 12, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 12, 2026
@david-allison
david-allison deleted the 21753-1 branch September 12, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericli3690 ericli3690 ericli3690 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.25 release

Development

Successfully merging this pull request may close these issues.

2 participants

@david-allison @ericli3690